fix(route): add prefix /api for routes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhmnmbr
approved these changes
Mar 21, 2023
Comment on lines
21
to
25
| const handler = new Handler(usecase, this.logger) | ||
| this.http.app.get('/v1/banners', handler.Banner()) | ||
| this.http.app.get('/v1/activities', handler.Activity()) | ||
| this.http.app.get('/v1/activities/:id', handler.ActivityByID()) | ||
| this.http.app.get('api/v1/banners', handler.Banner()) | ||
| this.http.app.get('api/v1/activities', handler.Activity()) | ||
| this.http.app.get('api/v1/activities/:id', handler.ActivityByID()) | ||
| } |
There was a problem hiding this comment.
why the route name is used the prefix api. Usually, the api prefix is in the api domain.
Ex: api.aljabar.jabarprov.go.id
this comment is for avoiding redundant prefix naming with api.
There was a problem hiding this comment.
continue discussion to chat telegram yes
|
it's already merged 1 minutes ago 😿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
/apifor routesEvidence