Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jabarprov): add a external from jabarprov go id #2

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

ayocodingit
Copy link
Collaborator

@ayocodingit ayocodingit commented Mar 9, 2023

Overview

  • feat(Jabarprov): add an external from Jabarprov go id

Evidence

@ayocodingit ayocodingit self-assigned this Mar 9, 2023
@azophy
Copy link
Member

azophy commented Mar 9, 2023

Quick question, because this is just a wrapper for jabarprov website, why dont just let frontend directly access jabarprov website? I think that way it would means less things to take care of in the backend side.

@ayocodingit
Copy link
Collaborator Author

ayocodingit commented Mar 9, 2023

Quick question, because this is just a wrapper for jabarprov website, why dont just let frontend directly access jabarprov website? I think that way it would means less things to take care of in the backend side.

interesting, I think to answer the question, my answer is I want the frontend just to have line one a URL for access to the backend, this is better than having many URLs, and then the goal other to protect from not consistent response JSON because the response from external have different response API, hope the answer helps 😄 #CMIIW

@azophy
Copy link
Member

azophy commented Mar 9, 2023

Quick question, because this is just a wrapper for jabarprov website, why dont just let frontend directly access jabarprov website? I think that way it would means less things to take care of in the backend side.

interesting, I think to answer the question, my answer is I want the frontend just to have line one a URL for access to the backend, this is better than having many URLs, and then the goal other to protect from not consistent response JSON because the response from external have different response API, hope the answer helps 😄 #CMIIW

alright make sense. thanks for answering 👍

src/external/jabarprov.ts Outdated Show resolved Hide resolved
@ayocodingit ayocodingit merged commit a1a859c into main Mar 9, 2023
@ayocodingit ayocodingit deleted the feat(jabarprov)-external-from-jabar-prov branch March 9, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants