Feat: disable calendar #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsellavaleria19
approved these changes
May 31, 2024
rayfajars
approved these changes
May 31, 2024
Ibwedagama
approved these changes
May 31, 2024
Comment on lines
480
to
485
| formatDate(date, 'yyyy-MM-dd') < | ||
| formatDate(this.thisDay, 'yyyy-MM-dd') || | ||
| (formatDate(date, 'yyyy-MM-dd') === | ||
| formatDate(this.thisDay, 'yyyy-MM-dd') && | ||
| getCurrentTime() > sessionStartTime) | ||
| ) |
There was a problem hiding this comment.
minor:
hello @rizfirman I think this function can be simplified to improve readability wdyt? 🤔
getDisabledDate(date, sessionStartTime) {
const dateToCompare = formatDate(date, 'yyyy-MM-dd')
const today = formatDate(this.thisDay, 'yyyy-MM-dd')
const currentTime = getCurrentTime()
const isBeforeToday = dateToCompare < today
const isAfterSessionStart= (dateToCompare === today) && (currentTime > sessionStartTime)
return isBeforeToday || isAfterSessionStart
} There was a problem hiding this comment.
hi, @Ibwedagama i already implementing it coz this solution is more easy to read. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
CMS Sribaduga - View Kalendar Reservasi
Changes
Preview
Evidence
title: make date disable when date option < currentDate
project: Jabar Super Apps
participants: @rizfirman @marsellavaleria19 @rayfajars @Ibwedagama