fix: cross-platform compat

Cargo.toml

@@ -37,7 +37,7 @@ rust-2018-idioms = "deny"
 rust-2021-compatibility = "deny"
 
 [workspace.lints.clippy]
-all = "deny"
+all = { level = "deny", priority = -1 }
 match_same_arms = "deny"
 semicolon_if_nothing_returned = "deny"
 single_match_else = "deny"

compiler/src/typechecker.rs

@@ -75,7 +75,7 @@ impl<'a> TypeChecker<'a> {
                     }
                 } else {
                     let mut checked = Vec::with_capacity(exprs.len());
-                    for expr in exprs.iter() {
+                    for expr in exprs {
                         let val = match expected {
                             Some(TypeId::Array(elem)) => self.check_and_convert(expr, elem, scope)?,
                             _ => self.check(expr, None, scope)?,

scc/lib-tests/tests/tests.rs

@@ -1,10 +1,16 @@
+#[cfg(windows)]
 use std::ffi::CString;
-use std::{fs, mem};
+#[cfg(windows)]
+use std::fs;
+use std::mem;
 
+#[cfg(windows)]
 use assert_fs::prelude::*;
+#[cfg(windows)]
 use minidl::*;
 use scc_lib_tests::*;
 
+#[cfg(windows)]
 #[test]
 fn api_functions_are_stable() {
     // this test just ensures that the API types haven't changed
@@ -68,6 +74,7 @@ fn api_types_are_stable() {
     assert_eq!(SccSourceRefType_SCC_SOURCE_REF_TYPE_ENUM, 4);
 }
 
+#[cfg(windows)]
 #[test]
 fn compiles_successfully() {
     let temp = assert_fs::TempDir::new().unwrap();
@@ -152,6 +159,7 @@ fn compiles_successfully() {
     temp.close().unwrap();
 }
 
+#[cfg(windows)]
 #[test]
 fn receives_an_error() {
     let temp = assert_fs::TempDir::new().unwrap();
@@ -196,6 +204,7 @@ fn receives_an_error() {
     temp.close().unwrap();
 }
 
+#[cfg(windows)]
 fn load_api() -> SccApi {
     let lib = Library::load("scc_lib.dll").unwrap();
     unsafe {

scc/lib/include/scc.h

@@ -1,6 +1,7 @@
 #ifndef SCC_H
 #define SCC_H
 
+#include <stddef.h>
 #include <stdint.h>
 #include <stdbool.h>
 

scc/lib/src/lib.rs

@@ -13,6 +13,7 @@ use flexi_logger::{Age, Cleanup, Criterion, Duplicate, FileSpec, LogSpecBuilder,
 use hashbrown::{HashMap, HashSet};
 use hints::UserHints;
 use log::LevelFilter;
+#[cfg(windows)]
 use normpath::PathExt;
 use redscript::ast::Span;
 use redscript::bundle::{ConstantPool, ScriptBundle};

scc/lib/tests/compile.rs

@@ -1,11 +1,14 @@
-use std::fs;
-use std::fs::{File, OpenOptions};
+#[cfg(windows)]
+use std::fs::{self, File, OpenOptions};
+#[cfg(windows)]
 use std::path::Path;
 use std::process::Command;
 
 use assert_cmd::prelude::*;
+#[cfg(windows)]
 use assert_fs::prelude::*;
 use predicates::prelude::*;
+#[cfg(windows)]
 use scc_lib::timestamp::*;
 
 #[test]
@@ -25,6 +28,7 @@ fn help() -> Result<(), Box<dyn std::error::Error>> {
     Ok(())
 }
 
+#[cfg(windows)]
 #[test]
 fn bundle_result() -> Result<(), Box<dyn std::error::Error>> {
     let temp = assert_fs::TempDir::new()?;
@@ -50,6 +54,7 @@ fn bundle_result() -> Result<(), Box<dyn std::error::Error>> {
     Ok(())
 }
 
+#[cfg(windows)]
 #[test]
 fn timestamp_migration() -> Result<(), Box<dyn std::error::Error>> {
     let temp = assert_fs::TempDir::new()?;
@@ -85,6 +90,7 @@ fn timestamp_migration() -> Result<(), Box<dyn std::error::Error>> {
     Ok(())
 }
 
+#[cfg(windows)]
 #[test]
 fn custom_output_clean() -> Result<(), Box<dyn std::error::Error>> {
     let temp = assert_fs::TempDir::new()?;
@@ -114,6 +120,7 @@ fn custom_output_clean() -> Result<(), Box<dyn std::error::Error>> {
     Ok(())
 }
 
+#[cfg(windows)]
 #[test]
 fn custom_output_with_restore() -> Result<(), Box<dyn std::error::Error>> {
     let temp = assert_fs::TempDir::new()?;