Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration #81

Merged
merged 7 commits into from
Oct 2, 2024
Merged

add configuration #81

merged 7 commits into from
Oct 2, 2024

Conversation

jacek-kurlit
Copy link
Owner

@jacek-kurlit jacek-kurlit commented Oct 1, 2024

What was done?

  • Added loading configuration from file at ~/.config/pik/config.toml
  • Created AppSettings that hold all settings tui requires (viewport and filtering option for now). Settings are built from config and cli args
  • Added logic to override app config with cli args
  • Changed default screen size to 25 lines
  • Some code refactor
  • Added tests

@jacek-kurlit jacek-kurlit added the enhancement New feature or request label Oct 1, 2024
@jacek-kurlit jacek-kurlit linked an issue Oct 1, 2024 that may be closed by this pull request
@jacek-kurlit
Copy link
Owner Author

@grouzen Would you like to make code review?

@grouzen
Copy link
Contributor

grouzen commented Oct 1, 2024

@jacek-kurlit I must say I just started learning Rust, so I can't really spot any non-ideomatic Rust code, but in terms of modularity and logic, it looks good to me! I like the new app settings module!

@jacek-kurlit jacek-kurlit merged commit 159d0b0 into main Oct 2, 2024
4 checks passed
@jacek-kurlit jacek-kurlit deleted the 10-add-configuration branch October 2, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration
3 participants