Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vim-like key bindings for navigation #89

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Oct 6, 2024

This PR simply adds support for Ctrl-J / Ctrl-K keys for moving up/down and also updates the documentation to use a markdown table for key bindings.

Copy link
Owner

@jacek-kurlit jacek-kurlit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pr
Seems like we are going to need help popup instead of current solution

@jacek-kurlit jacek-kurlit merged commit 7e88c70 into jacek-kurlit:main Oct 6, 2024
4 checks passed
@jacek-kurlit jacek-kurlit added the enhancement New feature or request label Oct 6, 2024
@orhun
Copy link
Contributor Author

orhun commented Oct 6, 2024

Can you elaborate? What do you mean by popup?

@jacek-kurlit
Copy link
Owner

Like this in lazygit
image

@orhun
Copy link
Contributor Author

orhun commented Oct 6, 2024

Okay, what is the current solution? 👀 I'm not sure if I'm following here

@jacek-kurlit
Copy link
Owner

#90

You may ignore my comment I was more talking to myself than to you :)
Current solution is simple help line at the bottom of the screen but the space is limited and I'm planning more search features (like displaying process family) so the time is right to take care of it

@orhun
Copy link
Contributor Author

orhun commented Oct 6, 2024

Ah I see, makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants