Proxy ticket service and proxy ticket validation #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekkow
requested changes
May 15, 2024
There was a problem hiding this comment.
These are just a few issues I have spotted by looking at the code - I have not checked the underlying logic yet. For example I'd like to check whether replacing "ST-" with "PGT-" in a service ticket would result in such token being invalid, as I'm not so sure now.
src/main/java/org/keycloak/protocol/cas/endpoints/ProxyValidateEndpoint.java
Outdated
Show resolved
Hide resolved
src/main/java/org/keycloak/protocol/cas/endpoints/AbstractValidateEndpoint.java
Outdated
Show resolved
Hide resolved
src/main/java/org/keycloak/protocol/cas/endpoints/AbstractValidateEndpoint.java
Outdated
Show resolved
Hide resolved
src/main/java/org/keycloak/protocol/cas/endpoints/AbstractValidateEndpoint.java
Outdated
Show resolved
Hide resolved
src/main/java/org/keycloak/protocol/cas/endpoints/AbstractValidateEndpoint.java
Outdated
Show resolved
Hide resolved
alexandrerw
commented
May 16, 2024
src/main/java/org/keycloak/protocol/cas/endpoints/AbstractValidateEndpoint.java
Show resolved
Hide resolved
|
@alexandrerw : Could you please squash all your changes into a single commit and apply changes from branch pr105: |
|
@alexandrerw : One more thing, remove "Proxy ticket service and proxy ticket validation [CAS 2.0]" from missing features section in README. |
Proxy endpoints improvements suggested by Jacek Kowalski Add ticket type to storage key Rename isreuse to isReusable Remove "parsing" of "codeUUID" that is String, not UUID Improve error reporting in CAS ticket validation
|
@jacekkow done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #37
Changelog:
/serviceValidate and /p3/serviceValidate with optional parameter "pgtUrl" create PGT and PGTIOU ticket, return a proxyGrantingTicket(PGTIOU).
/proxy receive a PGT ticket and exchange it for a PT ticket.
/proxyValidate and /p3/proxyValidate check if a PT ticket is valid.
Note: OAuth2CodeParser is not used because the PGT ticker is reusable, keycloak 23.0.0 and above generate an error.