Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Sass !default variables more specific to Checka11y #138

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Make Sass !default variables more specific to Checka11y #138

merged 2 commits into from
Oct 14, 2021

Conversation

jackdomleo7
Copy link
Owner

Enhancement/maintenance description

Why is this enhancement/maintenance important?

This is described in the linked issue.

Covered test cases

Regression

Did you test on all major browsers?

I couldn't test Safari because I don't have access to an Apple device.

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

N/A

T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge
  • I have updated the README, features.md and codes.md files where applicable

@jackdomleo7 jackdomleo7 added the project enhancement Enhancement to improving the overall project label Oct 14, 2021
@jackdomleo7 jackdomleo7 added this to the v2 milestone Oct 14, 2021
@jackdomleo7 jackdomleo7 self-assigned this Oct 14, 2021
@jackdomleo7 jackdomleo7 added the Hacktoberfest Hacktoberfest eligible label Oct 14, 2021
@jackdomleo7 jackdomleo7 merged commit 05ca98a into master Oct 14, 2021
@jackdomleo7 jackdomleo7 deleted the 130_less_generic_sass_variables branch October 14, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackdomleo7 jackdomleo7

Labels
Hacktoberfest Hacktoberfest eligible project enhancement Enhancement to improving the overall project
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Refactor Sass !default variables to have a less general name and more specific to Checka11y.css
1 participant
@jackdomleo7