Update dependencies to match gulp 4 #108
Conversation
use fancy-log
|
Maybe worth using gulplog? Nice work, though :) |
|
Agree with @callumacrae that I'd use Can you add yourself as a contributor in the |
|
I think it worth using https://github.com/tunnckoCore/load-deps under the hoods, it's pretty fast. Or just take a look and say some feedback :) Cheers, |
|
@tunnckoCore can you open a new issue? It's not related to this PR. |
adding myself to contributors list
|
I updated to use
For the first bullet, we could listen for the events and write to the console but this will result in duplicate logging when users are using Also, added my name to the contributors list, thanks! |
| pattern: ['gulp-*', 'gulp.*'], // the glob(s) to search for | ||
| config: 'package.json', // where to find the plugins, by default searched up from process.cwd() | ||
| scope: ['dependencies', 'devDependencies', 'peerDependencies'], // which keys in the config to look within | ||
| replaceString: /^gulp(-|\.)/, // what to remove from the name of the module when adding it to the context | ||
| camelize: true, // if true, transforms hyphenated plugins names to camel case | ||
| lazy: true, // whether the plugins should be lazy loaded on demand | ||
| rename: {}, // a mapping of plugins to rename | ||
| renameFn: function (name) { ... } // a function to handle the renaming of plugins (the default works) | ||
| renameFn: function (name) { ... }, // a function to handle the renaming of plugins (the default works) | ||
| DEBUG: true // when set to true and using gulp-cli flag -LLLL, the plugin will log info to console. Useful for bug reporting and issue debugging |
There was a problem hiding this comment.
can we keep this as false, as this shows the default values and DEBUG should be false by default.
|
@jackfranklin I reverted the DEBUG changes per your inline comments. |
|
Thank you! @callumacrae does this look good to you? :) |
|
Yep, looks good! |
|
@jackfranklin thanks for merging. Will you publish to npm? |
|
@doowb released as 1.2.3. Thanks :) |
This PR is to update dependencies to match some that are used in gulp 4.
gulp-utilfancy-logfor DEBUG loggingfindup-syncmicromatch(used infindup-syncandchokidarforgulp.watch)Since this is an attempt at consolidating common dependencies, I removed the green coloring around the logging messages. If you'd like to keep that, I can add something for it.