Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added renameFn #88

Merged
merged 2 commits into from
Oct 15, 2015
Merged

Added renameFn #88

merged 2 commits into from
Oct 15, 2015

Conversation

callumacrae
Copy link
Contributor

Resolves #82 cc/ @tcurdt

@jackfranklin
Copy link
Owner

This is awesome! ❤️

Maybe a quick README addition to explain if you define renameFn, the rename option gets ignored? Then 👍

@callumacrae
Copy link
Contributor Author

Donee

@jackfranklin
Copy link
Owner

👍 after this is there anything stopping us releasing 1.0.0 proper do you think?

@callumacrae
Copy link
Contributor Author

I reckon #70 and #80 probably both need looking at, but it doesn't look like that many people are having problems so I'd go for it :)

jackfranklin added a commit that referenced this pull request Oct 15, 2015
@jackfranklin
Merge pull request #88 from callumacrae/rename-fn
ace14ca 
Added renameFn
@jackfranklin jackfranklin merged commit ace14ca into jackfranklin:master Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@callumacrae @jackfranklin