Allow customization of the metrics path #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksontj
reviewed
Oct 8, 2020
cmd/promxy/main.go
Outdated
| @@ -74,6 +74,8 @@ type cliOpts struct { | |||
| WebCORSOriginRegex string `long:"web.cors.origin" description:"Regex for CORS origin. It is fully anchored." default:".*"` | |||
| WebReadTimeout time.Duration `long:"web.read-timeout" description:"Maximum duration before timing out read of the request, and closing idle connections." default:"5m"` | |||
|
|
|||
| MetricsPath string `long:"metrics-path" description:"url path" default:"/metrics"` | |||
There was a problem hiding this comment.
nit: the description here should specify that this is the path for the prometheus metrics endpoint.
There was a problem hiding this comment.
My latest change should address that :)
jacksontj
approved these changes
Oct 8, 2020
|
Perfect, Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring promxy's metrics path