Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring timeouts to skip slow server groups from queries #359

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

QuentinBisson
Copy link
Contributor

No description provided.

@QuentinBisson QuentinBisson force-pushed the skip-slow-server-groups branch from 88777e8 to ddf01ef Compare October 15, 2020 11:08
@jacksontj
Copy link
Owner

This feature seems like a good addition, one thing I'll clarify here is that this enforces a timeout which by default won't skip-- but combined with other options you can get the behavior you are looking for (I assume you know, mostly just odcing here for posterity :) ).

Just need to get CI to pass, I think #360 will fix it? But we'll have to see.

@QuentinBisson
Copy link
Contributor Author

I wanted to try this but I guess adding an extra round tripper around the transport one would make more sense

@jacksontj
Copy link
Owner

I guess I'm not following why a second round-tripper would be desierable? With the first commit it would enforce a timeout and return an error when that timeout was met; Then the user could use ignore_error to skip that slow one if they wanted -- otherwise the timeout would be enforced as configured.

@QuentinBisson
Copy link
Contributor Author

I think I misinterpreted your earlier message. Let me revert it back

@QuentinBisson QuentinBisson force-pushed the skip-slow-server-groups branch from 48f3741 to 801990c Compare October 15, 2020 15:16
Copy link
Owner

@jacksontj jacksontj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment in, I think we just drop the second commit and we're good to merge :)

pkg/servergroup/config.go Outdated Show resolved Hide resolved
@QuentinBisson QuentinBisson force-pushed the skip-slow-server-groups branch from 801990c to f9e998e Compare October 16, 2020 08:13
@jacksontj
Copy link
Owner

Thanks for the contribution! 🎉

@jacksontj jacksontj merged commit 9012d28 into jacksontj:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants