Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: push one value at a time to avoid stack overflows #43

Merged
merged 1 commit into from
Aug 11, 2024
Merged

fix: push one value at a time to avoid stack overflows #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/turbo-stream.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ test("should encode and decode object", async () => {

test("should encode and decode large payload", async () => {
const input: unknown[] = [];
for (let i = 0; i < 10000; i++) {
for (let i = 0; i < 100000; i++) {
input.push({
[Math.random().toString(36).slice(2)]: Math.random()
.toString(36)
Expand Down
4 changes: 3 additions & 1 deletion src/unflatten.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ export function unflatten(this: ThisDecode, parsed: unknown): unknown {
if (!Array.isArray(parsed) || !parsed.length) throw new SyntaxError();

const startIndex = values.length;
values.push(...parsed);
for (const value of parsed) {
values.push(value);
}
hydrated.length = values.length;

return hydrate.call(this, startIndex);
Expand Down
Loading