-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upkeep - fix doc issues + update CI + drop crayon #77
Conversation
…ead of custom logic.
… its tidying method.
… to avoid deprecation warning
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Thank you @olivroy! I made a couple changes to the actions since I deploy to Netlify rather than Github Pages, but otherwise this is great and super helpful! There's a check failure in these tests due to something I did in the main branch before merging but this looks good to go. |
Apologies for not noticing that! Thanks for your diligence |
I think that ggstance is no longer needed (due to change in jtools) https://cran.r-project.org/web/packages/jtools/news/news.html, but I noticed that broom.mixed was required to run tests, so I added it instead. This is helpful since ggstance is deprecated and the maintainer says the last release was the last one on CRAN.
Updated github actions with
usethis::use_github_action()
(you may get a failing coverage action, which is fixable by following guideline in r-lib/actions#834Removed a
linewidth
warning from ggplot2 3.5.0, (caught from running tests)I didn't update the vdiffr snapshots, since I am running the dev version of ggplot2 3.5.1.9000.
I replaced the tests wrapped in
if (requireNamespace())
by appropriateskip_if_not_installed()
instead.Happy to answer questions.
Cheers