Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upkeep - fix doc issues + update CI + drop crayon #77

Merged
merged 15 commits into from
Jul 28, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jul 22, 2024

I think that ggstance is no longer needed (due to change in jtools) https://cran.r-project.org/web/packages/jtools/news/news.html, but I noticed that broom.mixed was required to run tests, so I added it instead. This is helpful since ggstance is deprecated and the maintainer says the last release was the last one on CRAN.

Updated github actions with usethis::use_github_action() (you may get a failing coverage action, which is fixable by following guideline in r-lib/actions#834

Removed a linewidth warning from ggplot2 3.5.0, (caught from running tests)

I didn't update the vdiffr snapshots, since I am running the dev version of ggplot2 3.5.1.9000.

I replaced the tests wrapped in if (requireNamespace()) by appropriate skip_if_not_installed() instead.

Happy to answer questions.

Cheers

DESCRIPTION Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 28, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@jacob-long
Copy link
Owner

Thank you @olivroy! I made a couple changes to the actions since I deploy to Netlify rather than Github Pages, but otherwise this is great and super helpful! There's a check failure in these tests due to something I did in the main branch before merging but this looks good to go.

@jacob-long jacob-long merged commit 38ae938 into jacob-long:master Jul 28, 2024
3 of 10 checks passed
@olivroy
Copy link
Contributor Author

olivroy commented Jul 29, 2024

Apologies for not noticing that! Thanks for your diligence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants