feat: use native AbortController when possible #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
force-pushed
the
native-abort-signal
branch
2 times, most recently
from
f854157
to
13c4365
Compare
Gozala
force-pushed
the
native-abort-signal
branch
from
13c4365
to
f69a6a6
Compare
Gozala
added a commit
to ipfs/js-ipfs-utils
that referenced
this pull request
Aug 18, 2020
|
I don't think this works in the electron renderer which should be able to use native fetch/abort-controllers/etc, it still pulls in the node version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around mysticatea/abort-controller#24 in order to unblock ipfs/js-ipfs-utils#60