Refine NetOp #1
Merged
Refine NetOp #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OperatorBase should not store OpDesc, because not All op contains an
OpDesc and not all ops create from OpDesc.
* Networks do not contain OpDesc, and do not created by OpDesc
* Do not register Network to OpRegistry.
* The network is directly created by user in Python. Not from
registry.
* Correctly handle the `inputs` and `outputs` of a Network.
* Add CompleteAddOp() methods
* Remove `AddOp(OpDesc&)`. All op are added by pointer.
* Rewrite unit test for truely tested what networks do.
* Remove `DemoOp` and `DemoOpTest` because it is useless and break the
CI
jacquesqiao
pushed a commit
that referenced
this pull request
Sep 6, 2017
Invoke check_grad many times for no_grad_set
jacquesqiao
pushed a commit
that referenced
this pull request
Sep 19, 2017
jacquesqiao
pushed a commit
that referenced
this pull request
Oct 16, 2017
jacquesqiao
pushed a commit
that referenced
this pull request
Dec 5, 2017
fix pipe_reader unimport packages
jacquesqiao
pushed a commit
that referenced
this pull request
May 17, 2018
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle
jacquesqiao
pushed a commit
that referenced
this pull request
Jun 10, 2018
polish sparse update code
jacquesqiao
pushed a commit
that referenced
this pull request
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpDesc and not all ops create from OpDesc.
registry.
inputsandoutputsof a Network.AddOp(OpDesc&). All op are added by pointer.DemoOpandDemoOpTestbecause it is useless and break theCI