[MET-108] Don't scan all directories in the install when backing up #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2021 18:49
Enforces that replace_directories be directories starting in the root of the install directory
jackbentley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code that handles the
replace_directoriesconfig option to not scan the entire install directory. The user may not have permission to access some of the directories which causes the task to fatal error.Additionally, this PR will enforce that the config values are directories starting at the installation root. i.e.
/varor/var/configare at/patch/dir/varand/patch/dir/var/configrespectively.This PR also removes the undocumented ability to specify a pattern for the config option.