Fix Download links for v2 artifacts (#818)

## Which problem is this PR solving? - Resolves #817 Signed-off-by: Yuri Shkuro <github@ysh.us>
jaegertracing · Dec 17, 2024 · 229b8b8 · 229b8b8
1 parent 9378fff
commit 229b8b8
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/themes/basetheme/layouts/shortcodes/binaries.html b/themes/basetheme/layouts/shortcodes/binaries.html
@@ -1,4 +1,5 @@
-{{ $latestXXX        := .Site.Params.binariesLatest }}
+{{/* The releases on GitHub are currently tagged with v1xx tag, so we use $latestV1 in the base URLs */}}
+{{ $latestV1      := .Site.Params.binariesLatest }}
 {{ $binaries      := .Site.Data.download.binaries }}
 {{ $platforms     := $binaries.platforms }}
 <table class="table is-striped">
@@ -15,9 +16,9 @@
   <tbody>
   {{ $versions := slice .Site.Params.binariesLatestV2 .Site.Params.binariesLatest }}
   {{ range $latest := $versions }}
-    {{ $releaseUrl    := printf "https://github.com/jaegertracing/jaeger/releases/tag/v%s" $latest }}
-    {{ $zipUrl        := printf "https://github.com/jaegertracing/jaeger/archive/v%s.zip" $latest }}
-    {{ $tarUrl        := printf "https://github.com/jaegertracing/jaeger/archive/v%s.tar.gz" $latest }}
+    {{ $releaseUrl    := printf "https://github.com/jaegertracing/jaeger/releases/tag/v%s" $latestV1 }}
+    {{ $srcZipUrl     := printf "https://github.com/jaegertracing/jaeger/archive/v%s.zip" $latestV1 }}
+    {{ $srcTarUrl     := printf "https://github.com/jaegertracing/jaeger/archive/v%s.tar.gz" $latestV1 }}
     <tr>
       <td>
         <strong>
@@ -34,7 +35,7 @@
           {{ $name        := $platform.name }}
           {{ $icon        := $platform.icon }}
           {{ $asset       := printf "jaeger-%s-%s-amd64.tar.gz" $latest $key }}
-          {{ $downloadUrl := printf "https://github.com/jaegertracing/jaeger/releases/download/v%s/%s" $latest $asset }}
+          {{ $downloadUrl := printf "https://github.com/jaegertracing/jaeger/releases/download/v%s/%s" $latestV1 $asset }}
           {{ $zipUrl      := printf "https://github.com/jaegertracing/jaeger/archive/v%s.zip" $latest }}
           {{ $tarUrl      := printf "https://github.com/jaegertracing/jaeger/archive/v%s.tar.gz" $latest }}
           <a class="button is-medium is-{{ $key }}" href="{{ $downloadUrl }}" download>
@@ -46,15 +47,15 @@
             </span>
           </a>
           {{ end }}
-          <a class="button is-medium is-zip" href="{{ $zipUrl }}" download>
+          <a class="button is-medium is-zip" href="{{ $srcZipUrl }}" download>
             <span class="icon">
               <i class="fas fa-file-archive"></i>
             </span>
             <span>
               Source (.zip)
             </span>
           </a>
-          <a class="button is-medium is-tar" href="{{ $tarUrl }}" download>
+          <a class="button is-medium is-tar" href="{{ $srcTarUrl }}" download>
             <span class="icon">
               <i class="fas fa-file-archive"></i>
             </span>
@@ -67,4 +68,4 @@
     </tr>
   {{ end }}
   </tbody>
-</table>
+</table>