[jaeger] quote host name in ingress templates #572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Quote host name in ingress templates to prevents a yaml syntax error when using a host starting with a wildcard.
helm template . --set "query.ingress.enabled=true" --set "query.ingress.hosts[0]=*.example.test"
now has this output:Before the change it would try to render with
- host: *.example.test
which is invalid YAML because of the value starting with a*
.Which issue this PR fixes
Checklist
[jaeger]
or[jaeger-operator]
)