Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger] quote host name in ingress templates #572

Merged
merged 1 commit into from
May 6, 2024

Conversation

coryflucas
Copy link
Contributor

What this PR does

Quote host name in ingress templates to prevents a yaml syntax error when using a host starting with a wildcard.

helm template . --set "query.ingress.enabled=true" --set "query.ingress.hosts[0]=*.example.test" now has this output:

...
---
# Source: jaeger/templates/query-ing.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: release-name-jaeger-query
  labels:
    helm.sh/chart: jaeger-3.0.7
    app.kubernetes.io/name: jaeger
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "1.53.0"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/component: query
spec:
  rules:
    - host: "*.example.test"
      http:
        paths:
          - path: /
            pathType: ImplementationSpecific
            backend:
              service:
                name: release-name-jaeger-query
                port:
                  number: 80

Before the change it would try to render with - host: *.example.test which is invalid YAML because of the value starting with a *.

Which issue this PR fixes

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

this prevents a yaml syntax error when using a host starting with a wildcard

Signed-off-by: Cory Lucas <cory.lucas@aexp.com>
@pavelnikolov pavelnikolov merged commit f3c8839 into jaegertracing:main May 6, 2024
2 checks passed
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 1, 2024
Signed-off-by: mehul <mehulsharam4786@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Using ingress host starting with wildcard causes YAML parse error
2 participants