Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger] add new options, improvements into allInOne #586

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

rgaduput
Copy link
Contributor

What this PR does

  • [jaeger] allInOne add option automountServiceAccountToken for serviceaccount
  • [jaeger] allInOne add affinity support
  • [jaeger] allInOne add topologySpreadConstraints support
  • [jaeger] allInOne add podSecurityContext and containerSecurityContext support

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format,
will close that issue when PR gets merged)

  • fixes #

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

@pavelnikolov
Copy link
Contributor

@rgaduput make sure your commits are signed otherwise I cannot merge your PR.

Merging is blocked
The base branch requires all commits to be signed

@rgaduput
Copy link
Contributor Author

rgaduput commented Jun 26, 2024

@rgaduput make sure your commits are signed otherwise I cannot merge your PR.

Merging is blocked
The base branch requires all commits to be signed

@pavelnikolov yes all 4 commits are signed.
Below is how they are, hoping this is what expected otherwise please let me know
image

@pavelnikolov
Copy link
Contributor

pavelnikolov commented Jun 26, 2024

Screenshot 2024-06-26 at 9 46 24

https://docs.github.com/authentication/managing-commit-signature-verification/about-commit-signature-verification

You need to GPG sign the commits, not just provide your name and email.

@rgaduput
Copy link
Contributor Author

Screenshot 2024-06-26 at 9 46 24 The base branch requires all commits to be signed. Learn more about signing commits.
You need to GPG sign the commits, not just provide your name and email.

ok, let me see how to do that.

rgaduput added 4 commits June 26, 2024 13:38
…account

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
… support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
@rgaduput
Copy link
Contributor Author

Screenshot 2024-06-26 at 9 46 24 The base branch requires all commits to be signed. Learn more about signing commits.
You need to GPG sign the commits, not just provide your name and email.

ok, let me see how to do that.

@pavelnikolov Done all commits GPG signed now. Could you please check and merge

@pavelnikolov pavelnikolov merged commit 1dca639 into jaegertracing:main Jun 26, 2024
2 checks passed
@rgaduput
Copy link
Contributor Author

@pavelnikolov thanks,
Could you please take a look at the deployments due to some issue chart was not released https://github.com/jaegertracing/helm-charts/deployments/github-pages

@pavelnikolov
Copy link
Contributor

re-running fixed it, thanks

hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 1, 2024
* [jaeger] allInOne add option automountServiceAccountToken for serviceaccount

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add affinity support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add topologySpreadConstraints support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add podSecurityContext and containerSecurityContext support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

---------

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 2, 2024
* [jaeger] allInOne add option automountServiceAccountToken for serviceaccount

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add affinity support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add topologySpreadConstraints support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add podSecurityContext and containerSecurityContext support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

---------

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants