Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-operator] Add ingressclasses to role.yaml so that the CRD has correct permissions when rbac.cluster.Role is set #591

Merged
merged 2 commits into from
Jul 30, 2024
Merged

[jaeger-operator] Add ingressclasses to role.yaml so that the CRD has correct permissions when rbac.cluster.Role is set #591

merged 2 commits into from
Jul 30, 2024

Conversation

shivendoodeshmukh
Copy link
Contributor

What this PR does

Add ingressclasses to role.yaml so that the CRD has correct permissions when rbac.cluster.Role is set

Which issue this PR fixes

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

@shivendoodeshmukh
Update role.yaml to solve issue 581
23fc8e1 
Signed-off-by: shivendoodeshmukh <shivendoo@gcoea.ac.in>
@shivendoodeshmukh
Bump Chart Version
6248ca1 
Signed-off-by: shivendoodeshmukh <shivendoo@gcoea.ac.in>
@batazor batazor merged commit 64baeb5 into jaegertracing:main Jul 30, 2024
2 checks passed
@FraPazGal
Copy link

Seems the operator still reports issues with this:

$ helm install jaeger-operator jaegertracing/jaeger-operator --version 2.55.0
$ kubectl logs $POD --namespace=default
...
W0731 08:01:25.681117       1 reflector.go:539] pkg/mod/k8s.io/client-go@v0.29.3/tools/cache/reflector.go:229: failed to list *v1.IngressClass: ingressclasses.networking.k8s.io is forbidden: User "system:serviceaccount:default:jaeger-operator" cannot list resource "ingressclasses" in API group "networking.k8s.io" at the cluster scope
E0731 08:01:25.681154       1 reflector.go:147] pkg/mod/k8s.io/client-go@v0.29.3/tools/cache/reflector.go:229: Failed to watch *v1.IngressClass: failed to list *v1.IngressClass: ingressclasses.networking.k8s.io is forbidden: User "system:serviceaccount:default:jaeger-operator" cannot list resource "ingressclasses" in API group "networking.k8s.io" at the cluster scope

Probably requires adding the ingressclasses resource to the networking.k8s.io apiGroup in role.yaml

@kravciak kravciak mentioned this pull request Jul 31, 2024
Merged
5 tasks
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 1, 2024
@shivendoodeshmukh
[jaeger-operator] Add ingressclasses to role.yaml so that the CRD has…
b4eba18 
… correct permissions when rbac.cluster.Role is set (jaegertracing#591)

* Update role.yaml to solve issue 581

Signed-off-by: shivendoodeshmukh <shivendoo@gcoea.ac.in>

* Bump Chart Version

Signed-off-by: shivendoodeshmukh <shivendoo@gcoea.ac.in>

---------

Signed-off-by: shivendoodeshmukh <shivendoo@gcoea.ac.in>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batazor batazor Awaiting requested review from batazor batazor is a code owner

@cpanato cpanato Awaiting requested review from cpanato cpanato is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Jaeger Custom Resource not works
3 participants
@shivendoodeshmukh @FraPazGal @batazor