[jaeger] Add missing loadBalancerIp to collector-svc template #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K3ndu
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
|
@K3ndu thank you for your contribution. Could you, please, take care of the PR checklist? |
K3ndu
changed the title
K3ndu
force-pushed
the
main
branch
4 times, most recently
from
6fc6a17 to
49e2fdb
Compare
Should be okay now, theres only conflict with the chart version. What to do with that? |
Signed-off-by: Kendi Paet <kendi@tavex.eu>
|
I rebased your version against |
pavelnikolov
approved these changes
Sep 12, 2024
hellspawn679
pushed a commit
to hellspawn679/helm-charts
that referenced
this pull request
Nov 1, 2024
…tracing#601) Signed-off-by: Kendi Paet <kendi@tavex.eu> Signed-off-by: mehul <mehulsharam4786@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds missing loadbalancer ip to collector service
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format,will close that issue when PR gets merged)
Checklist
[jaeger]or[jaeger-operator])