Change sampler param sentinel value from YAML parser (#145)

* Change sampler param sentinel value Signed-off-by: andremarianiello <andremarianiello@users.noreply.github.com> * Add unit test for param=0 Signed-off-by: andremarianiello <andremarianiello@users.noreply.github.com>
jaegertracing · Jan 2, 2019 · fa8d376 · fa8d376
1 parent cefa941
commit fa8d376
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/jaegertracing/ConfigTest.cpp b/src/jaegertracing/ConfigTest.cpp
@@ -73,6 +73,18 @@ TEST(Config, testDefaultSamplingProbability)
               Config().sampler().param());
 }
 
+TEST(Config, testZeroSamplingParam)
+{
+    {
+        constexpr auto kConfigYAML = R"cfg(
+sampler:
+    param: 0
+)cfg";
+        const auto config = Config::parse(YAML::Load(kConfigYAML));
+        ASSERT_EQ(0, config.sampler().param());
+    }
+}
+
 #endif  // JAEGERTRACING_WITH_YAML_CPP
 
 }  // namespace jaegertracing
diff --git a/src/jaegertracing/samplers/Config.h b/src/jaegertracing/samplers/Config.h
@@ -61,7 +61,7 @@ class Config {
         const auto type =
             utils::yaml::findOrDefault<std::string>(configYAML, "type", "");
         const auto param =
-            utils::yaml::findOrDefault<double>(configYAML, "param", 0);
+            utils::yaml::findOrDefault<double>(configYAML, "param", -1);
         const auto samplingServerURL = utils::yaml::findOrDefault<std::string>(
             configYAML, "samplingServerURL", "");
         const auto maxOperations =
@@ -86,7 +86,7 @@ class Config {
         const Clock::duration& samplingRefreshInterval =
             defaultSamplingRefreshInterval())
         : _type(type.empty() ? kSamplerTypeRemote : type)
-        , _param(param == 0 ? kDefaultSamplingProbability : param)
+        , _param(param == -1 ? kDefaultSamplingProbability : param)
         , _samplingServerURL(samplingServerURL.empty()
                                  ? kDefaultSamplingServerURL
                                  : samplingServerURL)