This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Remote reporter flush fix #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Hier <isaachier@gmail.com>
isaachier
force-pushed
the
remote-reporter-flush-fix
branch
from
e837288 to
f27c912
Compare
isaachier
commented
Feb 9, 2018
| return; | ||
| } | ||
| _running = false; | ||
| flush(); |
There was a problem hiding this comment.
Most important line in this review.
There was a problem hiding this comment.
@rnburn suggested that flush() should only run - or at least only block - on an explicit call to Tracer.Close().
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 88.46% 88.51% +0.04%
==========================================
Files 93 93
Lines 2246 2246
==========================================
+ Hits 1987 1988 +1
+ Misses 259 258 -1
Continue to review full report at Codecov.
|
Signed-off-by: Isaac Hier <isaachier@gmail.com>
|
Tested and works for me here, passes the shortlived test proc. Thanks very much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guarantee a flush occurs on destruction of
RemoteReporter. Add morenoexceptspecifiers for reporter methods.