This repository has been archived by the owner on May 23, 2024. It is now read-only.
Change default metric namespace to use relevant separator for the met… #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric backend Signed-off-by: Gary Brown <gary@brownuk.com>
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
=======================================
Coverage 87.22% 87.22%
=======================================
Files 54 54
Lines 3006 3006
=======================================
Hits 2622 2622
Misses 272 272
Partials 112 112
Continue to review full report at Codecov.
|
pavolloffay
approved these changes
Jan 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ric backend
Signed-off-by: Gary Brown gary@brownuk.com
Which problem is this PR solving?
PR #346 changed the default namespace for tracer metrics to be
jaeger_tracer- however this is inconsistent with the separator used with other components (e.g. for expvar).Short description of the changes
This PR separates the two parts of the namespace, i.e.
jaegerandtracer, so the appropriate metrics backend separator is used.