Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Upgrade jaeger-lib to 2.2 and unpin Prom client #434

Merged
merged 4 commits into from
Sep 23, 2019

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 21, 2019

Resolves #433

Currently uses private branch of jaeger-lib, pending jaeger-lib 2.2 release

TODO:

Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Sep 21, 2019

Codecov Report

Merging #434 into master will decrease coverage by 7.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   92.06%   84.64%   -7.42%     
==========================================
  Files          22       33      +11     
  Lines        1625     1498     -127     
==========================================
- Hits         1496     1268     -228     
- Misses         87      168      +81     
- Partials       42       62      +20
Impacted Files Coverage Δ
zipkin.go
tracer.go
span.go
header.go
jaeger_thrift_span.go
tracer_options.go
interop.go
sampler.go
span_allocator.go
jaeger_tag.go
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f349093...ecf7b7d. Read the comment docs.

Yuri Shkuro added 2 commits September 23, 2019 16:55
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro yurishkuro marked this pull request as ready for review September 23, 2019 21:14
@yurishkuro yurishkuro changed the title [WIP] Upgrade jaeger-lib to 2.2 and unpin Prom client Upgrade jaeger-lib to 2.2 and unpin Prom client Sep 23, 2019
Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro
Copy link
Member Author

codecov seems to be going insane

@yurishkuro
Copy link
Member Author

Coverage change could be due to the fix to PACKAGE make var, which was previously empty, and potentially resulting in some coverage not being reported. Will need to sort it out separately, once there is a baseline.

@yurishkuro yurishkuro merged commit e95cd44 into jaegertracing:master Sep 23, 2019
@yurishkuro yurishkuro deleted the upgrade-prom-client branch September 23, 2019 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to prometheus/client_golang 1.0
2 participants