Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Allow configuring http client timeout #465

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Users are unable to configure http client timeout

Short description of the changes

sabrehagen and others added 3 commits March 13, 2019 02:49
Signed-off-by: Jackson Delahunt <jackson@stemn.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #465 (d9efad0) into master (8e6f4ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          50       50           
  Lines        2039     2044    +5     
  Branches      384      386    +2     
=======================================
+ Hits         2013     2018    +5     
  Misses         26       26           
Impacted Files Coverage Δ
src/configuration.js 99.00% <100.00%> (+0.02%) ⬆️
src/configuration_env.js 100.00% <100.00%> (ø)
src/reporters/http_sender.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6f4ec...d9efad0. Read the comment docs.

@yurishkuro yurishkuro merged commit f142943 into jaegertracing:master Apr 28, 2021
@yurishkuro yurishkuro deleted the fix-350 branch April 28, 2021 02:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants