Skip to content

Commit

Permalink
Change start/end time to non-nullable
Browse files Browse the repository at this point in the history
Signed-off-by: Yuri Shkuro <github@ysh.us>
  • Loading branch information
yurishkuro committed Nov 17, 2024
1 parent bdd5ab5 commit cd8351e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions proto/api_v2/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,13 @@ message GetTraceRequest {
];
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
}

Expand Down
6 changes: 4 additions & 2 deletions proto/api_v3/query_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ message GetTraceRequest {
string trace_id = 1;
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
}

Expand Down

0 comments on commit cd8351e

Please sign in to comment.