Skip to content

Commit

Permalink
[api_v2] Change time fields in ArchiveTraceRequest to non-nullable fo…
Browse files Browse the repository at this point in the history
…r gogo (#113)

## Which problem is this PR solving?
Part of jaegertracing/jaeger#4150

## Description of the changes
- Make sure type of time fields are aligned with other requests

## How was this change tested?
- unit test

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: rim99 <zhangxin@outlook.com>
  • Loading branch information
rim99 authored Nov 25, 2024
1 parent bb13310 commit de97430
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions proto/api_v2/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,13 @@ message ArchiveTraceRequest {
];
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
}

Expand Down

0 comments on commit de97430

Please sign in to comment.