Ensure Gopkg.lock files remain in sync with Gopkg.yaml #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned Signed-off-by: Prithvi Raj <p.r@uber.com>
vprithvi
force-pushed
the
fix-dep-glide
branch
from
64a52aa to
a73cb35
Compare
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 26 26
Lines 890 890
=====================================
Hits 890 890Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Jan 22, 2019
| [[constraint]] | ||
| name = "github.com/go-kit/kit" | ||
| version = "0.5.0" | ||
|
|
||
| [[constraint]] | ||
| name = "github.com/influxdata/influxdb" | ||
| name = "github.com/codahale/hdrhistogram" | ||
| branch = "master" |
There was a problem hiding this comment.
Is there some logic behind the reordering?
There was a problem hiding this comment.
Yes - I reordered it so that the dependencies are in the same order as glide.yaml so that they may be visually compared easier
Makefile
Outdated
| @@ -60,6 +63,9 @@ else | |||
| glide install | |||
| endif | |||
|
|
|||
| .PHONY: verify-dep | |||
| verify-dep: | |||
There was a problem hiding this comment.
I’d suggest doing away with the separate target, it doesn’t provide much value vs inline command
Signed-off-by: Prithvi Raj <p.r@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
dep checkwhich fails if these files are out of syncglide.yaml