Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GO15VENDOREXPERIMENT variable #71

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Aug 1, 2019

Which problem is this PR solving?

  • Removes GO15VENDOREXPERIMENT variable on development and CI.

Short description of the changes

  • Even at the inception of the project, as this project supports only Go 1.6+ 321ba1b, we do not need to have GO15VENDOREXPERIMENT.

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir
Copy link
Contributor Author

tnir commented Aug 1, 2019

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #71   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         890    890           
=====================================
  Hits          890    890

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d036253...9524fa4. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yurishkuro yurishkuro merged commit ec45623 into jaegertracing:master Aug 1, 2019
@tnir tnir deleted the remove-GO15VENDOREXPERIMENT branch August 1, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants