Implement fork.Factory #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement fork.Factory that deligates metrics with specific namespaces to different factory, otherwise default factory is used. Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 695 709 +14
=========================================
+ Hits 695 709 +14
Continue to review full report at Codecov.
|
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
|
cc @yurishkuro |
yurishkuro
reviewed
Sep 24, 2020
| "github.com/uber/jaeger-lib/metrics/go-kit", | ||
| "github.com/uber/jaeger-lib/metrics/go-kit/expvar", | ||
| "github.com/uber/jaeger-lib/metrics/metricstest", | ||
| "github.com/uber/jaeger-lib/metrics/prometheus", |
There was a problem hiding this comment.
which version of dep are you using? Ideally there should be no dependency changes in this PR.
There was a problem hiding this comment.
dep:
version : v0.5.4
build date : 2019-09-29
git hash : 1f7c19e
go version : go1.13
go compiler : gc
platform : darwin/amd64
features : ImportDuringSolve=false
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
yurishkuro
reviewed
Sep 25, 2020
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
yurishkuro
approved these changes
Sep 25, 2020
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
specific namespaces to different factory, otherwise
default factory is used.