Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply default buckets in Prometheus Factory #90

Merged

Conversation

moraitisk
Copy link
Contributor

Signed-off-by: Konstantinos Moraitis k.moraitis9@gmail.com

Which problem is this PR solving?

Short description of the changes

  • The prometheus factory determines which buckets to use when creating a Histogram.
    If the histogram options, provided as arguments, are empty, then the factory uses the default buckets.

Signed-off-by: Konstantinos Moraitis <k.moraitis9@gmail.com>
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #90 (d6def10) into master (78a0e7f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          709       713    +4     
=========================================
+ Hits           709       713    +4     
Impacted Files Coverage Δ
metrics/prometheus/factory.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d973d9...d6def10. Read the comment docs.

@yurishkuro yurishkuro merged commit 2f0f6fe into jaegertracing:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define default buckets for Prometheus Histogram
2 participants