Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOSSA scan enabled #1188

Closed

Conversation

idvoretskyi
Copy link

Ref.: cncf/foundation#109

Signed-off-by: Ihor Dvoretskyi ihor@linux.com

@idvoretskyi
Copy link
Author

cc @yurishkuro

@jpkrohling
Copy link
Contributor

LGTM, but I don't seem to have maintainer access to the repo:
image

@idvoretskyi
Copy link
Author

@jpkrohling I've invited you, let me know if you received an invitation.

@jpkrohling
Copy link
Contributor

I received, but looks like it's for registration? I have an account already (jpkroehling), and accessing the link from the email did not made me join the organization.

@idvoretskyi
Copy link
Author

I see. The issue is that FOSSA doesn't allow users to be members of multiple organizations (@yurishkuro had the same issue).

I can ask FOSSA support to move you from the existing organization to the CNCF one, or you can create a new FOSSA account for this purpose.

@jpkrohling
Copy link
Contributor

to move you from the existing organization to the CNCF one

Sure, sounds good.

@idvoretskyi
Copy link
Author

@jpkrohling this felt into cracks, my apologies. If this is still actual, I'll go ahead and work on adding you to the CNCF FOSSA org.

@jpkrohling
Copy link
Contributor

We still don't have FOSSA in this repo, and as long as contributors are able to clearly understand what is wrong in case of a failure, I think it would be nice to have.

Last commit reverted

Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1188 (187e4fe) into master (d941663) will decrease coverage by 1.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
- Coverage   88.30%   86.73%   -1.57%     
==========================================
  Files          89       91       +2     
  Lines        5506     5060     -446     
==========================================
- Hits         4862     4389     -473     
- Misses        474      516      +42     
+ Partials      170      155      -15     
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/freeform.go 71.42% <0.00%> (-5.50%) ⬇️
pkg/controller/jaeger/kafka.go 52.56% <0.00%> (-5.40%) ⬇️
pkg/upgrade/upgrade.go 55.68% <0.00%> (-5.30%) ⬇️
pkg/version/main.go 21.05% <0.00%> (-5.04%) ⬇️
pkg/controller/jaeger/kafkauser.go 52.00% <0.00%> (-4.63%) ⬇️
pkg/controller/jaeger/route.go 74.19% <0.00%> (-3.59%) ⬇️
pkg/controller/jaeger/secret.go 74.19% <0.00%> (-3.59%) ⬇️
pkg/controller/jaeger/account.go 74.19% <0.00%> (-3.59%) ⬇️
pkg/controller/jaeger/cronjob.go 74.19% <0.00%> (-3.59%) ⬇️
pkg/controller/jaeger/service.go 74.19% <0.00%> (-3.59%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d941663...187e4fe. Read the comment docs.

@jpkrohling
Copy link
Contributor

The check seems to be failing:

github.com/spf13/pflag imported from implicitly required module; to add
missing requirements, run:
	go get github.com/spf13/pflag@v1.0.5
LINK: https://github.com/fossas/fossa-cli/blob/master/docs/integrations/golang.md#analysis

FATAL Could not parse modules: No modules provided

@rubenvp8510 rubenvp8510 closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants