-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use time units in the Web UI which are easy to read by humans #319
Comments
please indicate which views you are referring to |
Not sure how they’re officially called but I guess any view would benefit. In particular I’m thinking about the search results view and the trace view. |
To add to this ticket, the time units to be displayed need to have a space after the number and before the time unit. for example:
UI example in figure: https://github.com/jaegertracing/jaeger-ui/blob/master/media/ss_trace.png I suppose this is as per the SI standards. |
Looks like the fix can go to https://github.com/jaegertracing/jaeger-ui/blob/master/packages/jaeger-ui/src/utils/date.tsx#L92 @yogeshVU my -1 was about spacing. I think |
Hello there, I found this issue because I was looking for an issue to work on as my first contribution and this one seemed pretty easy.
|
Expands the number of units that the formatDuration function displays. Previously the function only used milliseconds and seconds to display durations, now it will support all units up to days. This is to make it easier to read very long durations in the UI that would have previously only been displayed in seconds. As a side effect of this change, there are a few changes to the way existing durations are displayed: * 0ms -> 0μs * 0.15ms -> 150μs * 1.7s -> 1s 700ms Resolves jaegertracing#319 Signed-off-by: James Ferguson <jamesferguson497@gmail.com>
Expands the number of units that the formatDuration function displays. Previously the function only used milliseconds and seconds to display durations, now it will support all units up to days. This is to make it easier to read very long durations in the UI that would have previously only been displayed in seconds. As a side effect of this change, there are a few changes to the way existing durations are displayed: * 0ms -> 0μs * 0.15ms -> 150μs * 1.7s -> 1s 700ms Resolves jaegertracing#319 Signed-off-by: James Ferguson <jamesferguson497@gmail.com>
* Add more units to duration formatting Expands the number of units that the formatDuration function displays. Previously the function only used milliseconds and seconds to display durations, now it will support all units up to days. This is to make it easier to read very long durations in the UI that would have previously only been displayed in seconds. As a side effect of this change, there are a few changes to the way existing durations are displayed: * 0ms -> 0μs * 1.5μs * 1.5ms * 1.5s * 1m 30s * 1h 30m * 1d 12h Resolves #319 Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Remove inputUnit parameter of formatDuration The inputUnit parameter was not used anywhere and significantly complicated the implementation of the formatDuration function. Now, all inputs are assumed to be in microseconds which is consistent with a few other methods in the date.tsx file. Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Reduce date format units to 2 Reduces the number of units displayed by the dateFormat function to a maximum of 2. So "2d 5h 20m" will now be "2d 5h". Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Use decimals when formating μs, ms and s durations This change will display durations less than a minute using decimals as 1.3s is easier to comprehend than 1s 300ms as it was being displayed before. Durations larger than a minute will still use multiple units. Eg. 5m 27s Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Fix date.test.js licence Signed-off-by: James Ferguson <jamesferguson497@gmail.com>
* Add more units to duration formatting Expands the number of units that the formatDuration function displays. Previously the function only used milliseconds and seconds to display durations, now it will support all units up to days. This is to make it easier to read very long durations in the UI that would have previously only been displayed in seconds. As a side effect of this change, there are a few changes to the way existing durations are displayed: * 0ms -> 0μs * 1.5μs * 1.5ms * 1.5s * 1m 30s * 1h 30m * 1d 12h Resolves jaegertracing#319 Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Remove inputUnit parameter of formatDuration The inputUnit parameter was not used anywhere and significantly complicated the implementation of the formatDuration function. Now, all inputs are assumed to be in microseconds which is consistent with a few other methods in the date.tsx file. Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Reduce date format units to 2 Reduces the number of units displayed by the dateFormat function to a maximum of 2. So "2d 5h 20m" will now be "2d 5h". Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Use decimals when formating μs, ms and s durations This change will display durations less than a minute using decimals as 1.3s is easier to comprehend than 1s 300ms as it was being displayed before. Durations larger than a minute will still use multiple units. Eg. 5m 27s Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Fix date.test.js licence Signed-off-by: James Ferguson <jamesferguson497@gmail.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
* Add more units to duration formatting Expands the number of units that the formatDuration function displays. Previously the function only used milliseconds and seconds to display durations, now it will support all units up to days. This is to make it easier to read very long durations in the UI that would have previously only been displayed in seconds. As a side effect of this change, there are a few changes to the way existing durations are displayed: * 0ms -> 0μs * 1.5μs * 1.5ms * 1.5s * 1m 30s * 1h 30m * 1d 12h Resolves jaegertracing#319 Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Remove inputUnit parameter of formatDuration The inputUnit parameter was not used anywhere and significantly complicated the implementation of the formatDuration function. Now, all inputs are assumed to be in microseconds which is consistent with a few other methods in the date.tsx file. Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Reduce date format units to 2 Reduces the number of units displayed by the dateFormat function to a maximum of 2. So "2d 5h 20m" will now be "2d 5h". Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Use decimals when formating μs, ms and s durations This change will display durations less than a minute using decimals as 1.3s is easier to comprehend than 1s 300ms as it was being displayed before. Durations larger than a minute will still use multiple units. Eg. 5m 27s Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Fix date.test.js licence Signed-off-by: James Ferguson <jamesferguson497@gmail.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
* Add more units to duration formatting Expands the number of units that the formatDuration function displays. Previously the function only used milliseconds and seconds to display durations, now it will support all units up to days. This is to make it easier to read very long durations in the UI that would have previously only been displayed in seconds. As a side effect of this change, there are a few changes to the way existing durations are displayed: * 0ms -> 0μs * 1.5μs * 1.5ms * 1.5s * 1m 30s * 1h 30m * 1d 12h Resolves jaegertracing#319 Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Remove inputUnit parameter of formatDuration The inputUnit parameter was not used anywhere and significantly complicated the implementation of the formatDuration function. Now, all inputs are assumed to be in microseconds which is consistent with a few other methods in the date.tsx file. Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Reduce date format units to 2 Reduces the number of units displayed by the dateFormat function to a maximum of 2. So "2d 5h 20m" will now be "2d 5h". Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Use decimals when formating μs, ms and s durations This change will display durations less than a minute using decimals as 1.3s is easier to comprehend than 1s 300ms as it was being displayed before. Durations larger than a minute will still use multiple units. Eg. 5m 27s Signed-off-by: James Ferguson <jamesferguson497@gmail.com> * Fix date.test.js licence Signed-off-by: James Ferguson <jamesferguson497@gmail.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Requirement - what kind of business use case are you trying to solve?
Always use time units in the Web UI which are easy to read by humans.
We use Jaeger to trace some complex, long-running offline jobs in which a seconds granularity in the Web UI is too fine-grained for human consumption.
Problem - what in Jaeger blocks you from solving the requirement?
Currently, durations seem to be shown in either milliseconds (“ms”) or seconds (“s”). For traces of long-running requests/jobs a duration like “26904.23s” is not very readable.
Proposal - what do you suggest to solve the problem or improve the existing situation?
Instead of showing a duration like “26904.23s”, a duration like “7.47 h” or even “7 h 28 m 24.23 s” would be better for human consumption.
The text was updated successfully, but these errors were encountered: