Use logfmt for search tag input format #147
Conversation
Signed-off-by: Joe Farro <joef@uber.com>
tiffon
requested review from
black-adder,
vprithvi,
yurishkuro and
saminzadeh
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 93.04% 92.76% -0.28%
==========================================
Files 85 85
Lines 1854 1881 +27
Branches 359 366 +7
==========================================
+ Hits 1725 1745 +20
- Misses 119 124 +5
- Partials 10 12 +2
Continue to review full report at Codecov.
|
| @@ -128,6 +140,7 @@ export function TraceSearchFormImpl(props) { | |||
| const selectedServicePayload = services.find(s => s.name === selectedService); | |||
| const operationsForService = (selectedServicePayload && selectedServicePayload.operations) || []; | |||
| const noSelectedService = selectedService === '-' || !selectedService; | |||
| // const tagInfoIcon = <i className="info circle icon" />; | |||
| Values should be in the{' '} | ||
| <a href="https://brandur.org/logfmt" rel="noopener noreferrer" target="_blank"> | ||
| logfmt | ||
| </a>{' '} |
There was a problem hiding this comment.
perhaps we could give an example, save people a click
e.g.
db.statement="select * from User". Use space for conjunctions:error=true http.status_code:503
There was a problem hiding this comment.
The placeholder has two examples. But, I can add a few to the info tooltip, including one that uses quotes.
There was a problem hiding this comment.
Nevermind, I see your note now. I'll add that to the tooltip 👍
|
There is one more thing I want to change before this is merged: how tag names without values in the old format are handled. |
Signed-off-by: Joe Farro <joef@uber.com>
|
@yurishkuro Updated tooltip. Slight variation from your suggestion. Look ok?
|
|
great! |
…fmt-tag-search-input Use logfmt for search tag input format Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Fixes #145.
Fixes #11.
Changes the input format for tag matching in the search for to logfmt. Now populates a
tagsquery string parameter when submitting the search HTTP request. ThetagsGET param is JSON with all values converted to strings (per this comment).This change is backward compatible with URLs that have the former format. When the old format (
key:value|key2:value2) is in the URL, it is still parsed but added to the form in the logfmt format.Added a tooltip that links to information on logfmt.