Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second copy icon for value only #1505

Merged
merged 5 commits into from
Jun 17, 2023
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 17, 2023

Which problem is this PR solving?

Short description of the changes

  • Adds a second Copy icon that copies value only
  • Change Copy JSON icon to snippets, to be visually different
  • Reduce fade-out time for tooltip

Original Copy JSON was added in #292 / #312.

Signed-off-by: Yuri Shkuro <ysh@meta.com>
Signed-off-by: Yuri Shkuro <ysh@meta.com>
Signed-off-by: Yuri Shkuro <ysh@meta.com>
Signed-off-by: Yuri Shkuro <ysh@meta.com>
Signed-off-by: Yuri Shkuro <ysh@meta.com>
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (4834ea7) 95.63% compared to head (a7c576d) 95.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   95.63%   95.60%   -0.03%     
==========================================
  Files         245      245              
  Lines        7712     7712              
  Branches     2028     2028              
==========================================
- Hits         7375     7373       -2     
- Misses        337      339       +2     
Impacted Files Coverage Δ
.../TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx 97.82% <ø> (ø)
...kages/jaeger-ui/src/components/common/CopyIcon.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit beca0a8 into jaegertracing:main Jun 17, 2023
@yurishkuro yurishkuro deleted the fix-1503 branch June 17, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: copy log entry VALUE as is
1 participant