Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fallback trace name to be more informative #192

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Mar 1, 2018

Fix #190.

Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon requested a review from yurishkuro March 1, 2018 19:15
@ghost ghost assigned tiffon Mar 1, 2018
@ghost ghost added the review label Mar 1, 2018
@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

Merging #192 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #192      +/-   ##
=========================================
+ Coverage    91.4%   91.5%   +0.09%     
=========================================
  Files          95      95              
  Lines        2130    2130              
  Branches      434     434              
=========================================
+ Hits         1947    1949       +2     
+ Misses        162     160       -2     
  Partials       21      21
Impacted Files Coverage Δ
src/constants/index.js 100% <100%> (ø) ⬆️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 90.74% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7fc85...3a83c17. Read the comment docs.

@black-adder
Copy link
Contributor

Can we also add one of them scroll over info thingies (I'm a UX professional as you can tell) that says what root-span is missing means? ie It happens because the root service is poorly instrumented or the root span hasn't been persisted yet because it's the last span in a trace to be finished and persisted.

@tiffon
Copy link
Member Author

tiffon commented Mar 4, 2018

@black-adder Added a ticket from your comment, #193.

@tiffon tiffon merged commit 2e6d1a4 into master Mar 4, 2018
@ghost ghost removed the review label Mar 4, 2018
@yurishkuro yurishkuro deleted the issue-190-trace-without-root-span branch January 29, 2020 15:07
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants