Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Travis Integration #2

Merged
merged 4 commits into from
Apr 12, 2017
Merged

Adding Travis Integration #2

merged 4 commits into from
Apr 12, 2017

Conversation

saminzadeh
Copy link
Member

No description provided.

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d1a29b2 on travis into ** on master**.

@yurishkuro
Copy link
Member

it seems the lint is generating a lot of complaints, yet not causing any errors.

yurishkuro
yurishkuro requested changes Apr 11, 2017
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, even the test seems to generate a lot of errors, but the build succeeds

@saminzadeh
Copy link
Member Author

Those are only React library propTypes errors. We should fix them but they don't affect run time.

Also, that does not have anything to do with the Travis integration and should be fixed outside this PR request. The test are still passing accurately.

@yurishkuro
Copy link
Member

What about these logs from the tests?

image

image

I don't mind if we fix those separately, but my question related to this PR is whether those should be considered errors and fail the unit tests.

@saminzadeh
Copy link
Member Author

We should clean those up so messages so they don't show up, but the asserts are still passing for what we are testing. I think we should do that in a separate PR and have travis and coveralls setup independently.

@yurishkuro yurishkuro merged commit f8e68d0 into master Apr 12, 2017
@tiffon tiffon mentioned this pull request Nov 24, 2018
Merged
@tiffon tiffon mentioned this pull request Dec 17, 2018
Open
@yurishkuro yurishkuro deleted the travis branch January 29, 2020 15:04
vvvprabhakar referenced this pull request in vvvprabhakar/jaeger-ui Jul 5, 2021
@saminzadeh @yurishkuro
Adding Travis Integration (#2)
ddc2c12 
* Add travis file
* Add coveralls
* Add travis badge to readme

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saminzadeh @CLAassistant @coveralls @yurishkuro