-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development of a directed graph component #208
Conversation
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Outstanding: * tests * calculate edges via several workers when there are many edges Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
@simonrobb Can you look this over when you get the chance? |
Could you please separate the lerna-related refactoring into a separate PR and land it? |
@yurishkuro See #209. |
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Codecov Report
@@ Coverage Diff @@
## develop-directed-graph #208 +/- ##
==========================================================
+ Coverage 89.13% 89.17% +0.04%
==========================================================
Files 104 104
Lines 2291 2291
Branches 466 466
==========================================================
+ Hits 2042 2043 +1
+ Misses 210 209 -1
Partials 39 39
Continue to review full report at Codecov.
|
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
* Prep the repo for separately developed components * Fix uberinternal yarn.lock issues * Upgrade react to 16.3.2 * Update readme to account for on Lerna changes Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
High level
I'm breaking this down into chunks by targeting the
develop-directed-graph
branch instead ofmaster
.The repo has been reorganized to use Lerna with the main Jaeger UI app moved into
packages/jaeger-ui
and the directed graph is being developed inpackages/plexus
. Lerna is being used to make consumption of the component in Jaeger UI easier during development. The component is being broken out into it's own NPM package because it will be used in other projects, as well."plexus"
Wiktionary - plexus
Component
The directed graph will be used in:
This PR implements the functionality to generate the layout (positions and edges) of a graph, but does not have the presentation functionality (React component), yet.
Trying to move briskly due to time constraints, so comments are very light and unit tests are TODO. I wanted to get some eyes on this while moving onto the presentation layer.