Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development of a directed graph component #208

Closed
wants to merge 12 commits into from

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented May 2, 2018

High level

I'm breaking this down into chunks by targeting the develop-directed-graph branch instead of master.

The repo has been reorganized to use Lerna with the main Jaeger UI app moved into packages/jaeger-ui and the directed graph is being developed in packages/plexus. Lerna is being used to make consumption of the component in Jaeger UI easier during development. The component is being broken out into it's own NPM package because it will be used in other projects, as well.

"plexus"

  1. A network or interwoven mass, especially (anatomy) of nerves, blood vessels, or lymphatic vessels.

  2. (mathematics) The system of equations required for the complete expression of the relations which exist between a set of quantities.

Wiktionary - plexus

Component

The directed graph will be used in:

  • Service dependency graphs
  • Viewing a trace as a DAG
  • Comparing two traces via comparing two DAGs

This PR implements the functionality to generate the layout (positions and edges) of a graph, but does not have the presentation functionality (React component), yet.

Trying to move briskly due to time constraints, so comments are very light and unit tests are TODO. I wanted to get some eyes on this while moving onto the presentation layer.

tiffon added 5 commits April 19, 2018 04:39
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Outstanding:
* tests
* calculate edges via several workers when there are many edges

Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon requested a review from saminzadeh May 2, 2018 18:16
@ghost ghost assigned tiffon May 2, 2018
@ghost ghost added the review label May 2, 2018
@tiffon
Copy link
Member Author

tiffon commented May 2, 2018

@simonrobb Can you look this over when you get the chance?

@yurishkuro
Copy link
Member

so comments are very light and unit tests are TODO. I wanted to get some eyes on this while moving onto the presentation layer.

Could you please separate the lerna-related refactoring into a separate PR and land it?

@tiffon tiffon mentioned this pull request May 2, 2018
@tiffon
Copy link
Member Author

tiffon commented May 2, 2018

@yurishkuro See #209.

@tiffon
Copy link
Member Author

tiffon commented May 2, 2018

cc @whistlinwilly

tiffon added 2 commits May 2, 2018 16:39
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #208 into develop-directed-graph will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           develop-directed-graph     #208      +/-   ##
==========================================================
+ Coverage                   89.13%   89.17%   +0.04%     
==========================================================
  Files                         104      104              
  Lines                        2291     2291              
  Branches                      466      466              
==========================================================
+ Hits                         2042     2043       +1     
+ Misses                        210      209       -1     
  Partials                       39       39
Impacted Files Coverage Δ
...nents/TracePage/TraceTimelineViewer/TimelineRow.js 100% <ø> (ø)
...aceTimelineViewer/SpanDetail/AccordianKeyValues.js 100% <ø> (ø)
...nts/TracePage/TraceTimelineViewer/SpanDetailRow.js 100% <ø> (ø)
...i/src/components/TracePage/SpanGraph/TickLabels.js 100% <ø> (ø)
packages/jaeger-ui/src/selectors/dependencies.js 100% <ø> (ø)
...c/components/TracePage/TraceTimelineViewer/duck.js 100% <ø> (ø)
packages/jaeger-ui/src/utils/configure-store.js 100% <ø> (ø)
packages/jaeger-ui/src/components/App/index.js 100% <ø> (ø)
packages/jaeger-ui/src/utils/sort.js 100% <ø> (ø)
packages/jaeger-ui/src/constants/index.js 100% <ø> (ø)
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8349e...70edb78. Read the comment docs.

tiffon and others added 4 commits May 3, 2018 11:40
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
* Prep the repo for separately developed components
* Fix uberinternal yarn.lock issues
* Upgrade react to 16.3.2
* Update readme to account for on Lerna changes

Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon closed this May 11, 2018
@ghost ghost removed the review label May 11, 2018
@yurishkuro yurishkuro deleted the directed-graph branch January 29, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants