Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Make jaeger-ui installable #249

Closed
wants to merge 1 commit into from

Conversation

aljesusg
Copy link
Contributor

Which problem is this PR solving?

Issue #248 Make jaeger-ui installable

Short description of the changes

Change package.json to be public, add babel-preset-react-app to compile components

@aljesusg aljesusg changed the title [Working] Make jaeger-ui installable WIP Make jaeger-ui installable Sep 19, 2018
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #249 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   78.61%   78.57%   -0.04%     
==========================================
  Files         135      135              
  Lines        2927     2927              
  Branches      607      607              
==========================================
- Hits         2301     2300       -1     
- Misses        495      496       +1     
  Partials      131      131
Impacted Files Coverage Δ
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 88.88% <0%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d148dc5...ad7ffa9. Read the comment docs.

@tiffon
Copy link
Member

tiffon commented Sep 20, 2018

I have reservations about wholesale publishing the UI as a component library. I added a comment to #248:

One drawback for wholesale publishing the React components, in their current form, is that when all of the components become public, their combined API becomes the API contract. That's a massive contract. So much so it would essentially become impossible to maintain backwards compatibility while making any significant changes to the UI.

So, if we go down the path of publishing React components, I think the approach outlined by @saminzadeh would make the API contract more manageable.

I'm not sure publishing the current site is the most manageable approach, in the long-term. Let's discuss in #248?

@aljesusg
Copy link
Contributor Author

I agree @tiffon, this was only a WIP and test about how to handle this, we shoukd discuss if create another package called ui-kit like saminzadeh proposed and create/move there the components or transform this one so this has no sense. I'll close this. Thanks

@aljesusg aljesusg closed this Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants