Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Package UI-Kit #254

Closed
wants to merge 1 commit into from
Closed

WIP Package UI-Kit #254

wants to merge 1 commit into from

Conversation

aljesusg
Copy link
Contributor

Which problem is this PR solving?

Create a UI-KIT package #248 with a minor component

Short description of the changes

Moved TimelineRow to UI-KIT package.
I added the configuration for tests and utils/date.js for check it.

@aljesusg aljesusg changed the title Ui kit Package UI-Kit Sep 26, 2018
@aljesusg aljesusg changed the title Package UI-Kit WIP Package UI-Kit Sep 26, 2018
@aljesusg aljesusg force-pushed the ui-kit branch 2 times, most recently from e7dbfb2 to ac3376e Compare September 26, 2018 12:16
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #254 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage    77.6%   77.47%   -0.14%     
==========================================
  Files         135      134       -1     
  Lines        2934     2925       -9     
  Branches      608      608              
==========================================
- Hits         2277     2266      -11     
- Misses        520      522       +2     
  Partials      137      137
Impacted Files Coverage Δ
...nts/TracePage/TraceTimelineViewer/SpanDetailRow.js 100% <ø> (ø) ⬆️
...onents/TracePage/TraceTimelineViewer/SpanBarRow.js 80% <ø> (ø) ⬆️
...elineViewer/TimelineHeaderRow/TimelineHeaderRow.js 100% <ø> (ø) ⬆️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 87.03% <0%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6b248...f305976. Read the comment docs.

@aljesusg aljesusg closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant