Hide child status icon on SpanTreeOffset used in SpanDetailRow component #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 83.08% 83.14% +0.06%
==========================================
Files 142 142
Lines 3181 3181
Branches 654 654
==========================================
+ Hits 2643 2645 +2
+ Misses 431 429 -2
Partials 107 107
Continue to review full report at Codecov.
|
|
Possible a bit pedantic but I think |
tiffon
approved these changes
Feb 22, 2019
|
@everett980 is ok, after sending the PR I was thinking the same. :) So no problem I'll change the name |
ghost
assigned 
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Joe Farro <joef@uber.com>
…enIcon Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
rubenvp8510
force-pushed
the
Issue-328
branch
from
5ec5ac2 to
5809311
Compare
Thanks! 🎉 |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…ent (jaegertracing#334) * Hide child status icon on SpanTreeOffset used in SpanDetailRow component Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Small tweak to flow type Signed-off-by: Joe Farro <joef@uber.com> * Rename showChildrenStatus attribute from SpanTreeOffset to showChildrenIcon Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
SpanTreeOfsetis used for indentSpanDetailsRow