Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lodash to 4.17.11 #343

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Update lodash to 4.17.11 #343

merged 1 commit into from
Mar 11, 2019

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Mar 10, 2019

Uses yarn's selective resolutions to pin all uses of lodash to 4.17.11.

Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon requested a review from everett980 March 10, 2019 18:26
@ghost ghost assigned tiffon Mar 10, 2019
@ghost ghost added the review label Mar 10, 2019
@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #343 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   83.18%   83.25%   +0.06%     
==========================================
  Files         145      145              
  Lines        3224     3224              
  Branches      660      660              
==========================================
+ Hits         2682     2684       +2     
+ Misses        434      432       -2     
  Partials      108      108
Impacted Files Coverage Δ
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 90.74% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a179bf...5a93e9f. Read the comment docs.

@tiffon tiffon merged commit ac64772 into master Mar 11, 2019
@ghost ghost removed the review label Mar 11, 2019
@yurishkuro yurishkuro deleted the update-lodash branch January 29, 2020 15:07
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants