Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export plexus type declarations, remove Neutrino #348

Merged
merged 5 commits into from
Mar 19, 2019
Merged

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Mar 16, 2019

Build plexus as ES modules as well as a UMD module. The ES modules have accompanying *.d.ts type declarations. This is possible because layout.worker is being bundled into a self-contained UMD module (which initializes a Worker from a Blob URL). Therefore, the rest of the files can be ES modules.

Change the ES module build to be the default entry point.

Remove Neutrino and deal with Babel, Webpack and TypeScript, directly.

TODO

  • Publish plexus@0.1.0 when this PR is approved

tiffon added 2 commits March 16, 2019 03:51
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon requested a review from everett980 March 16, 2019 08:18
@ghost ghost assigned tiffon Mar 16, 2019
@ghost ghost added the review label Mar 16, 2019
Signed-off-by: Joe Farro <joef@uber.com>
@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #348 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   90.69%   90.75%   +0.06%     
==========================================
  Files         152      152              
  Lines        3288     3288              
  Branches      666      666              
==========================================
+ Hits         2982     2984       +2     
+ Misses        251      249       -2     
  Partials       55       55
Impacted Files Coverage Δ
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 90.74% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5edfd...6a998e8. Read the comment docs.

@yurishkuro
Copy link
Member

plexus@0.0.2-dev.0

why this ver? patch number is for bug fixes, you're adding new functionality. Of backwards compatibility is not a stated goal at this point, go with 0.1.0, 0.2.0, etc.

tiffon added 2 commits March 16, 2019 19:01
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like it was fun! It's clearer, the BUILD.md file is still a doozy but inconjunction with the package.json it makes sense. One note about the .eslintrc but otherwise LGTM.

@@ -29,9 +29,13 @@ module.exports = {
'prettier/@typescript-eslint',
],
rules: {
// use @typescript-eslint/no-useless-constructor to avoid null error on *.d.ts files
'no-useless-constructor': 0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this rule is being changed only because of *.d.ts files I believe we can define overrides, something like:

  overrides: [
    {
      files: ['*.d.ts'],
      rules: {
        'no-useless-constructor': 0,
      },
    },
  ],

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's for *.tsx files, as well. This override allow for the estlint-disable no-useless-constructor comments to be removed from files.

@tiffon tiffon merged commit faf6fc9 into master Mar 19, 2019
@ghost ghost removed the review label Mar 19, 2019
@yurishkuro yurishkuro deleted the plexus-type-defs branch January 29, 2020 15:07
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Export plexus type declarations, remove Neutrino
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants