-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export plexus type declarations, remove Neutrino #348
Conversation
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 90.69% 90.75% +0.06%
==========================================
Files 152 152
Lines 3288 3288
Branches 666 666
==========================================
+ Hits 2982 2984 +2
+ Misses 251 249 -2
Partials 55 55
Continue to review full report at Codecov.
|
why this ver? patch number is for bug fixes, you're adding new functionality. Of backwards compatibility is not a stated goal at this point, go with 0.1.0, 0.2.0, etc. |
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not look like it was fun! It's clearer, the BUILD.md
file is still a doozy but inconjunction with the package.json it makes sense. One note about the .eslintrc
but otherwise LGTM.
@@ -29,9 +29,13 @@ module.exports = { | |||
'prettier/@typescript-eslint', | |||
], | |||
rules: { | |||
// use @typescript-eslint/no-useless-constructor to avoid null error on *.d.ts files | |||
'no-useless-constructor': 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this rule is being changed only because of *.d.ts
files I believe we can define overrides, something like:
overrides: [
{
files: ['*.d.ts'],
rules: {
'no-useless-constructor': 0,
},
},
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's for *.tsx files, as well. This override allow for the estlint-disable no-useless-constructor
comments to be removed from files.
Export plexus type declarations, remove Neutrino Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Build plexus as ES modules as well as a UMD module. The ES modules have accompanying
*.d.ts
type declarations. This is possible becauselayout.worker
is being bundled into a self-contained UMD module (which initializes a Worker from a Blob URL). Therefore, the rest of the files can be ES modules.Change the ES module build to be the default entry point.
Remove Neutrino and deal with Babel, Webpack and TypeScript, directly.
TODO
plexus@0.1.0
when this PR is approved