-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ddg menu item, fetch server ops, expand GA cov #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 92.87% 92.92% +0.04%
==========================================
Files 197 197
Lines 4757 4789 +32
Branches 1151 1155 +4
==========================================
+ Hits 4418 4450 +32
Misses 298 298
Partials 41 41
Continue to review full report at Codecov.
|
vprithvi
approved these changes
Dec 19, 2019
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Temp: Default link visible with banner Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Use server ops in ddg, track conv&collapse Signed-off-by: Everett Ross <reverett@uber.com> * Add tests Signed-off-by: Everett Ross <reverett@uber.com> * Remove DDG announcement banner Signed-off-by: Everett Ross <reverett@uber.com> * Remove default ddg.menuEnabled Signed-off-by: Everett Ross <reverett@uber.com> * Add ddg.menuEnabled to types/config Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
deepDependencies.menuEnabled
fromconfig.json
and add Menu link if it is/deep-dependencies
to search results DDG ifdeepDependencies.menuEnabled
istrue