Usage of a helper for trace name when preparing trace data #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of a helper for trace name resolution when preparing traces data. It affects Search and Compare pages. Signed-off-by: Valerii Varankin <swapster@yandex-team.ru>
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
- Coverage 93.00% 92.89% -0.12%
==========================================
Files 197 200 +3
Lines 4848 4912 +64
Branches 1177 1212 +35
==========================================
+ Hits 4509 4563 +54
- Misses 299 309 +10
Partials 40 40
Continue to review full report at Codecov.
|
|
Any updates here? |
* Test for trace without an ID * Test for trace with remote (missing) root span * Test for trace with root span without refs Signed-off-by: Valerii Varankin <swapster@yandex-team.ru>
Added some tests. |
yurishkuro
reviewed
Apr 6, 2020
| key: 'http.status_code', | ||
| type: 'float64', | ||
| value: 200, | ||
| }, |
There was a problem hiding this comment.
Nit: are these tags relevant to the functionality being tested? They don't look like it. Could you please trim the fixtures to minimally required data?
There was a problem hiding this comment.
Sounds reasonable, thanks :)
Removed unnecessary tags.
Tags has been removed since it are not relevant to the functionality being tested Signed-off-by: Valerii Varankin <swapster@yandex-team.ru>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Usage of getTraceName() when preparing trace data Usage of a helper for trace name resolution when preparing traces data. It affects Search and Compare pages. Signed-off-by: Valerii Varankin <swapster@yandex-team.ru> * Tests for transform-trace-data helper * Test for trace without an ID * Test for trace with remote (missing) root span * Test for trace with root span without refs Signed-off-by: Valerii Varankin <swapster@yandex-team.ru> * Removed unnecessary data from tests Tags has been removed since it are not relevant to the functionality being tested Signed-off-by: Valerii Varankin <swapster@yandex-team.ru> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
This was referenced Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continue of #541.
Now there is a
getTraceName()method that can deal with a "root spans" with missing references. But it doesn't use when traces data transforms for a "Search" and "Compare" pages.Seems like it should be using here.