Trace quality view & Ddg Decorations #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
details panel, render details in details card TODO: Style table, handle list, handle styled values Signed-off-by: Everett Ross <reverett@uber.com>
TODO: Style table, handle list, handle styled values Signed-off-by: Everett Ross <reverett@uber.com>
clickable ddg nodes, fix resizer height css, make top offset css var TODO: Style table, handle list, handle styled values Signed-off-by: Everett Ross <reverett@uber.com>
TODO: Style table overflow, handle styled values Signed-off-by: Everett Ross <reverett@uber.com>
TODO: Handle styled values, loading&err render, modal, beautification Signed-off-by: Everett Ross <reverett@uber.com>
style card TODO: Add info modal Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
decoration header size, destructured variable order, DeepDependencies/index initial state, stale comments, yarn.lock @types/node, yarn.lock registry urls, 'value' in paths, existing tests, op-specific details Add: linking row cells TODO: New tests Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
memoize summary requests TODO: Test SidePanel/ index, index.track, DetailsPanel Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
TODO: Render banner text, style components, test Signed-off-by: Everett Ross <reverett@uber.com>
TODO: Render banner text, render weight, test Signed-off-by: Everett Ross <reverett@uber.com>
metric documentation tooltip, tweak styles, add BannerText, handle loading, handle error TODO: test, cleanup Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 214 214
Lines 5210 5210
Branches 1326 1326
=======================================
Hits 4686 4686
Misses 481 481
Partials 43 43 Continue to review full report at Codecov.
|
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* WIP: Action and types for decorations Signed-off-by: Everett Ross <reverett@uber.com> * Add PAD reducer, fix types, fix year Signed-off-by: Everett Ross <reverett@uber.com> * Fix and test reducer, fix types, fix another year Signed-off-by: Everett Ross <reverett@uber.com> * Add another pad reducer test Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Begin testing action Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Finish action tests TODO: Move stringSupplant Signed-off-by: Everett Ross <reverett@uber.com> * Move and test stringSupplant Signed-off-by: Everett Ross <reverett@uber.com> * Cleanup Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Decorate nodes, selector/detail side panel Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Style side panel Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Continue styling side panel, fetch details in details panel, render details in details card TODO: Style table, handle list, handle styled values Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Improve TS handling of union of arrays TODO: Style table, handle list, handle styled values Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Limit % circle size, update cursor for clickable ddg nodes, fix resizer height css, make top offset css var TODO: Style table, handle list, handle styled values Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Handle list, begin overflow management TODO: Style table overflow, handle styled values Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Manage overflow, begin handling styled values TODO: Handle styled values, loading&err render, modal, beautification Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Handle styled values, render loading&err, style card TODO: Add info modal Signed-off-by: Everett Ross <reverett@uber.com> * Add info modal, begin clean up TODO clean up&test Signed-off-by: Everett Ross <reverett@uber.com> * Fix: rowKeys, setViewModifier argument name, decoration header size, destructured variable order, DeepDependencies/index initial state, stale comments, yarn.lock @types/node, yarn.lock registry urls, 'value' in paths, existing tests, op-specific details Add: linking row cells TODO: New tests Signed-off-by: Everett Ross <reverett@uber.com> * Handle linked cells, fix cell sort order Signed-off-by: Everett Ross <reverett@uber.com> * Test existing files, track decorations viewed, memoize summary requests TODO: Test SidePanel/ index, index.track, DetailsPanel Signed-off-by: Everett Ross <reverett@uber.com> * Test SidePanel/ index&track WIP test DetailsPanel Signed-off-by: Everett Ross <reverett@uber.com> * WIP test DetailsPanel Signed-off-by: Everett Ross <reverett@uber.com> * Finish DetailsPanel tests Signed-off-by: Everett Ross <reverett@uber.com> * Clean up Signed-off-by: Everett Ross <reverett@uber.com> * Add skeleton components and fetch quality metrics Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Render all data and dropdowns except banner TODO: Render banner text, style components, test Signed-off-by: Everett Ross <reverett@uber.com> * WIP: Style components, implement lookback TODO: Render banner text, render weight, test Signed-off-by: Everett Ross <reverett@uber.com> * Debounce InputNumber, limit search url length, add metric documentation tooltip, tweak styles, add BannerText, handle loading, handle error TODO: test, cleanup Signed-off-by: Everett Ross <reverett@uber.com> * Cleanup Signed-off-by: Everett Ross <reverett@uber.com> * Add support for decoration links Signed-off-by: Everett Ross <reverett@uber.com> * Clean up and add quality-metrics top nav link Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Decorated DDG: