Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize getTraceName to improve render time by 3x #572

Merged

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

Short description of the changes

  • Memoizing getTraceName() by traceID cuts the calls to getTraceName() in third, improving performance for a trace with 10k spans from ~51s to ~17s.

Signed-off-by: Everett Ross <reverett@uber.com>
@everett980 everett980 requested a review from yurishkuro May 12, 2020 17:17
@everett980 everett980 requested a review from tiffon as a code owner May 12, 2020 17:17
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #572 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   90.05%   90.09%   +0.04%     
==========================================
  Files         214      214              
  Lines        5210     5211       +1     
  Branches     1327     1327              
==========================================
+ Hits         4692     4695       +3     
+ Misses        475      473       -2     
  Partials       43       43              
Impacted Files Coverage Δ
...ents/TracePage/TracePageHeader/TracePageHeader.tsx 96.42% <ø> (ø)
packages/jaeger-ui/src/model/trace-viewer.tsx 100.00% <100.00%> (ø)
...kages/jaeger-ui/src/model/transform-trace-data.tsx 89.41% <100.00%> (ø)
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 91.52% <0.00%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5aecd...d36c0d0. Read the comment docs.

@yurishkuro yurishkuro merged commit 4d140e5 into jaegertracing:master May 12, 2020
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants