Make detailscard table columns filterable #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
TODO: Finish cancel, style, test, verify single select FilteredList Signed-off-by: Everett Ross <reverett@uber.com>
TODO: Test, fix FilteredList styles, four tooltips Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
yurishkuro
approved these changes
May 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
==========================================
+ Coverage 93.43% 93.53% +0.09%
==========================================
Files 216 217 +1
Lines 5227 5289 +62
Branches 1337 1360 +23
==========================================
+ Hits 4884 4947 +63
+ Misses 302 301 -1
Partials 41 41
Continue to review full report at Codecov.
|
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* WIP: Add FilterDropdown to DetailsCard _makeColumn TODO: Finish cancel, style, test, verify single select FilteredList * WIP: Add cancel, style, verify old FilteredLists TODO: Test, fix FilteredList styles, four tooltips * Add tooltips, fix height, -empty filters, test * Handle cancel after click outside list, fix tips * Clean up Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
filterDropdownto antdTableused incommon/DetailsCardcommon/FilteredListNote
Builds off of this PR which should be reviewed and merged first.
This diff is encapsulated in these five commits.